This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Potentially improve performance of /jalist #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LinkedList of `clickables` will contain as many entries as there are snitches to display, potentially thousands. Then this loop https://github.com/CivMC/CivModCore/blob/master/paper/src/main/java/vg/civcraft/mc/civmodcore/inventory/gui/MultiPageView.java#L47 will call `.get()` on the list ~45 times per each page. Because it's a linked list, each `.get()` will be O(n). Pretty bad. The list never seems to get modified after creation, so there's literally no benefit to use a linked list over an array here, only massive downsides.
Diet-Cola
approved these changes
Dec 18, 2023
okx-code
reviewed
Dec 18, 2023
paper/src/main/java/com/untamedears/jukealert/gui/SnitchOverviewGUI.java
Outdated
Show resolved
Hide resolved
Co-authored-by: okx-code <okx@okx.sh>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LinkedList of
clickableswill contain as many entries as there are snitches to display, so potentially thousands.Then this loop will call
.get()on the list ~45 times per page. Because it's a linked list, each.get()will be O(n). Moreover, because it's not just iterating through the list, but rather incrementing an integer and calling.get(i), the performance is as bad as can be.The list never seems to get modified after creation, so there's literally no benefit to using a linked list over an array here, only massive downsides.
Not tested 🤷🏽♀️